linux-kernel - Re: [PATCH 1/2] TTY: ami_serial, remove BTM from wait_until

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201107131456.28333.arnd@arndb.de>
Date:	Wed, 13 Jul 2011 14:56:28 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...e.de, jirislaby@...il.com, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, Alan Cox <alan@...ux.intel.com>,
	Andreas Bombe <aeb@...ian.org>
Subject: Re: [PATCH 1/2] TTY: ami_serial, remove BTM from wait_until_sent

On Wednesday 13 July 2011, Jiri Slaby wrote:
> The same as in "TTY: serial, remove BTM from wait_until_sent" we don't
> need to take BTM in wait_until_sent of ami_serial. Exactly the same
> as serial, ami_serial accesses some "info" members (xmit_fifo_size,
> timeout), but their assignment on other places in the code is not
> protected by BTM anyway.
> 
> So the BTM protects nothing here. This removal helps us to get rid of
> tty_locked() and __big_tty_mutex_owner in the following patch. This
> was suggested by Arnd.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Greg Kroah-Hartman <gregkh@...e.de>
> Cc: Alan Cox <alan@...ux.intel.com>
> Cc: Andreas Bombe <aeb@...ian.org>

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/