linux-kernel - Re: [PATCH] Input: cy8ctmg110_ts - set reset_pin and irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110713142055.3036c62d@lxorguk.ukuu.org.uk>
Date:	Wed, 13 Jul 2011 14:20:55 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Samuli Konttila <samuli.konttila@...amobile.com>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Alan Cox <alan@...ux.intel.com>, linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: cy8ctmg110_ts - set reset_pin and irq_pin from
 platform data

On Wed, 13 Jul 2011 21:06:59 +0800
Axel Lin <axel.lin@...il.com> wrote:

> The implementation in cy8ctmg110_probe() does not properly set reset_pin
> and irq_pin from platform data. Let's fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
> Current implementation returns -ENODEV if no pdata available.
> But it does not use the information from pdata.
> I think currently the driver does not work because both ts->reset_pin and ts->irq_pin are 0, then gpio_request with ts->irq_pin will fail.
> 
> Just found this bug while reading the code.
> I don't have this hardware. I appreciate if someone can test it.

Looks right, but I'm likewise unable to test it as I no longer have
access to a device using it.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/