linux-kernel - Re: [stable] [PATCH] FS-Cache: Fix bounds check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 13 Jul 2011 22:41:43 +0200
From:	Greg KH <greg@...ah.com>
To:	David Howells <dhowells@...hat.com>
Cc:	geert@...ux-m68k.org, linux-kernel@...r.kernel.org,
	stable@...nel.org
Subject: Re: [stable] [PATCH] FS-Cache: Fix bounds check

On Wed, Jul 13, 2011 at 12:55:18PM +0100, David Howells wrote:
> __fscache_uncache_all_inode_pages() has a loop that goes through page index
> numbers go up to (loff_t)-1.  This is incorrect.  The limit should be
> (pgoff_t)-1 as on a 32-bit machine the pgoff_t is smaller than loff_t.
> 
> On m68k the following error is observed:
> 
> fs/fscache/page.c: In function '__fscache_uncache_all_inode_pages':
> fs/fscache/page.c:979: warning: comparison is always false due to
> limited range of data type
> 
> [Should there be a PGOFF_T_MAX constant defined?]
> 
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Signed-off-by: David Howells <dhowells@...hat.com>
> ---
> 
>  fs/fscache/page.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)


<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read Documentation/stable_kernel_rules.txt
for how to do this properly.

</formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/