linux-kernel - Re: Linux 2.6.32.43 (WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1310592945.1662.27.camel@Joe-Laptop>
Date:	Wed, 13 Jul 2011 14:35:45 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jiri Slaby <jslaby@...e.cz>, David Miller <davem@...emloft.net>,
	saidone <saidone@...done.org>
Cc:	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	torvalds@...ux-foundation.org, stable@...nel.org, lwn@....net
Subject: Re: Linux 2.6.32.43 (WARN_RATELIMIT)

On Wed, 2011-07-13 at 23:28 +0200, Jiri Slaby wrote:
> Cced Joe.

Thanks Jiri.

I didn't submit this patch for stable.
I don't even try to track stable.

Saidone also notified me, I just replied to him
and cc'd stable.  Perhaps I should have cc'd lkml
as well.  Saidone's proposed patch is attached.

cheers, Joe

> On 07/13/2011 11:21 PM, Jiri Slaby wrote:
> > On 07/13/2011 11:16 PM, Jiri Slaby wrote:
> >> On 07/13/2011 05:45 AM, Greg KH wrote:
> >>> Joe Perches (2):
> >>>       bug.h: Add WARN_RATELIMIT
> >>>       net: filter: Use WARN_RATELIMIT
> >>
> >> Hi, this causes a build failure on PPC with minimalistic config (PS3) [1]:
> >> net/core/filter.c: In function 'sk_run_filter':
> >> net/core/filter.c:297: error: implicit declaration of function
> >> 'WARN_RATELIMIT'
> >>
> >> net/core/filter.c should include linux/bug.h (or linux/kernel.h).
> > 
> > Ah, no, PS3 doesn't have CONFIG_BUG set.
> 
> A fix attached. Upstream doesn't need it. There it is all in
> linux/ratelimit.h
> 
> >> [1]
> >> http://gitorious.org/opensuse/kernel-source/blobs/SLE11-SP1/config/ppc/ps3
> >>
> >> regards,



Return-Path: <saidone@...done.org>
X-Original-To: joe@...ches.com
Delivered-To: joe@...ches.com
Received: from smtp207.alice.it (smtp207.alice.it [82.57.200.103]) by
 mail.perches.com (Postfix) with ESMTP id ACDB224368 for <joe@...ches.com>;
 Wed, 13 Jul 2011 10:44:42 -0700 (PDT)
Received: from kugelmass.saidonet (80.183.18.56) by smtp207.alice.it
 (8.5.124.08) id 4DFA189A02D4036E; Wed, 13 Jul 2011 19:44:49 +0200
Received: from [192.168.1.1] (nicoletta-desktop.saidonet [192.168.1.1]) by
 kugelmass.saidonet (Postfix) with ESMTP id 4A282B2; Wed, 13 Jul 2011
 19:44:47 +0200 (CEST)
Message-ID: <4E1DD98E.5030903@...done.org>
Date: Wed, 13 Jul 2011 19:44:46 +0200
From: saidone <saidone@...done.org>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17)
 Gecko/20110424 Thunderbird/3.1.10
MIME-Version: 1.0
To: Joe Perches <joe@...ches.com>
CC: stable <stable@...nel.org>
Subject: Re: WARN_RATELIMIT
References: <4E1D7560.7060502@...done.org>
	 <1310568751.1662.13.camel@...-Laptop>
In-Reply-To: <1310568751.1662.13.camel@...-Laptop>
Content-Type: text/plain; charset=UTF-8; format=flowed
Status:   
X-Evolution-Source: pop://joe@....168.1.1/
Content-Transfer-Encoding: 7bit

Hi Joe, I found that the problem was that I have debugfs disabled (# 
CONFIG_BUG is not set).
I cannot make better than this patch to net/core/filter.c:

  #ifdef CONFIG_BUG
                         WARN_RATELIMIT(1, "Unknown code:%u jt:%u tf:%u 
k:%u\n",
                                        fentry->code, fentry->jt,
                                        fentry->jf, fentry->k);
                         #endif
                         #ifndef CONFIG_BUG
                         WARN_ON(1);
                         #endif
                         return 0;

However, at least, it works ;-)
Thank you very much for the hints,

Marco Marini

On 13/07/2011 16:52, Joe Perches wrote:
> On Wed, 2011-07-13 at 12:37 +0200, saidone wrote:
>> Hello Joe,
>> I tried to build the latest stable kernel 2.6.32.43 with gcc 3.4.6, but
>> it stopped while compiling filter.c:
>> net/core/filter.c: In function `sk_run_filter':
>> net/core/filter.c:294: error: implicit declaration of function
>> `WARN_RATELIMIT'
>> How can I patch it in a "safe" manner?
>> Thanks in advance,
>> Marco Marini
>
> I believe net/core/filter.c will need to
>
> #include<linux/ratelimit.h>