linux-kernel - Re: [PATCH 2/12] mm: let swap use exceptional entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110713161121.17fd98a4.akpm@linux-foundation.org>
Date:	Wed, 13 Jul 2011 16:11:21 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 2/12] mm: let swap use exceptional entries

On Tue, 12 Jul 2011 15:08:58 -0700 (PDT)
Hugh Dickins <hughd@...gle.com> wrote:

> > All the crap^Wnice changes made to filemap.c really need some comments,
> > please.  Particularly when they're keyed off the bland-sounding
> > "radix_tree_exception()".  Apparently they have something to do with
> > swap, but how is the poor reader to know this?
> 
> The naming was intentionally bland, because other filesystems might
> in future have other uses for such exceptional entries.
> 
> (I think the field size would generally defeat it, but you can,
> for example, imagine a small filesystem wanting to save sector number
> there when a page is evicted.)
> 
> But let's go bland when it's more familiar, and such uses materialize -
> particularly since I only placed those checks in places where they're
> needed now for shmem/tmpfs/swap.
> 
> I'll keep the bland naming, if that's okay, but send a patch adding
> a line of comment in such places.  Mentioning shmem, tmpfs, swap.

A better fix would be to create a nicely-documented filemap-specific
function with a non-bland name which simply wraps
radix_tree_exception().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/