linux-kernel - Re: [PATCH 30/30] Staging: comedi: fix printk() issue in das16m1.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110714074144.GR18655@shale.localdomain>
Date:	Thu, 14 Jul 2011 10:41:44 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 30/30] Staging: comedi: fix printk() issue in das16m1.c

On Thu, Jul 14, 2011 at 10:12:27AM +0530, Ravishankar wrote:
> @@ -690,7 +690,7 @@ static int das16m1_attach(struct comedi_device *dev,
>  	if (!request_region(iobase + DAS16M1_82C55, DAS16M1_SIZE2,
>  			    driver_das16m1.driver_name)) {
>  		release_region(iobase, DAS16M1_SIZE);
> -		printk(" I/O port conflict\n");
> +		printk(KERN_ERR " I/O port conflict\n");

This is a continuation of the last printk line.

>  		return -EIO;
>  	}
>  	dev->iobase = iobase;
> @@ -710,7 +710,7 @@ static int das16m1_attach(struct comedi_device *dev,
>  	} else if (irq == 0) {
>  		printk(", no irq\n");
>  	} else {
> -		printk(", invalid irq\n"
> +		printk(KERN_ERR ", invalid irq\n"

Same.

If you want you can just rewrite the printks completely.  You're not
just limited to adding the KERN_ prefixes, you could make larger
changes than that.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/