linux-kernel - Re: [PATCH 1/3] Staging: comedi: fix warning issue in daqboard2000.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110714075950.GS18655@shale.localdomain>
Date:	Thu, 14 Jul 2011 10:59:50 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Ravishankar <ravishankarkm32@...il.com>
Cc:	gregkh@...e.de, wfp5p@...ginia.edu, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Ravishankar <ravi.shankar@...enturtles.in>
Subject: Re: [PATCH 1/3] Staging: comedi: fix warning issue in daqboard2000.c

On Thu, Jul 14, 2011 at 11:32:13AM +0530, Ravishankar wrote:
>     2. The initialization done so far is:
> -        a. program the FPGA (windows code sans a lot of error messages)
> +	a.program the FPGA(windows code sans a lot of error messages)
          ^
Space needed here.


>  
> -        Word0:
> -          +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> -          ! | | | ! | | | ! | | | ! | | | !
> -          +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> +	Word0:
> +	  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
> +	  !|||!|||!|||!|||!
> +	  +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

No.  The original comment is a diagram and you have destroyed it
completely.

You are writing all these patches to do the minimum needed to make
check patch happy.  Check patch is not a human being.  Do not write
code to please check patch, because it feels no sadness or happiness.

You have made yourself into a servant of a shell script.  Have some
dignity.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/