linux-kernel - Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110714080830.GA7149@linutronix.de>
Date:	Thu, 14 Jul 2011 10:08:30 +0200
From:	Sebastian Andrzej Siewior <bigeasy@...utronix.de>
To:	Yuan-Hsin Chen <yhchen@...aday-tech.com>
Cc:	Felipe Balbi <balbi@...com>, Greg Kroah-Hartman <gregkh@...e.de>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 4/5] fusb300_udc: Add missing breaks in switch/case

* Joe Perches | 2011-07-10 02:28:27 [-0700]:

>Signed-off-by: Joe Perches <joe@...ches.com>
>---
> drivers/usb/gadget/fusb300_udc.c |    3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
>diff --git a/drivers/usb/gadget/fusb300_udc.c b/drivers/usb/gadget/fusb300_udc.c
>index 06353e7..453bc0f 100644
>--- a/drivers/usb/gadget/fusb300_udc.c
>+++ b/drivers/usb/gadget/fusb300_udc.c
>@@ -688,10 +688,13 @@ static void fusb300_cmp_dbg_fifo(struct fusb300_ep *ep,
> 	switch (length % 4) {
> 	case 1:
> 		golden_value = *tmp;
>+		break;
> 	case 2:
> 		golden_value = *tmp | *(tmp + 1) << 8;
>+		break;
> 	case 3:
> 		golden_value = *tmp | *(tmp + 1) << 8 | *(tmp + 2) << 16;
>+		break;
> 	default:
> 		break;
> 

That is in an #if 0 block. Maybe we should remove the #if 0? Yuan-Hsin?

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/