linux-kernel - Re: [PATCH] HID: ACRUX - add missing hid_hw_stop() in ax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107141143230.7300@pobox.suse.cz>
Date:	Thu, 14 Jul 2011 11:43:31 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Dmitry Torokhov <dtor@...l.ru>,
	Sergei Kolzun <x0r@...life.ru>, linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: ACRUX - add missing hid_hw_stop() in ax_probe()
 error path

On Thu, 14 Jul 2011, Axel Lin wrote:

> hid_hw_stop() must be called in ax_probe() error path if hid_hw_start()
> was successful.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/hid/hid-axff.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-axff.c b/drivers/hid/hid-axff.c
> index b455428..1215141 100644
> --- a/drivers/hid/hid-axff.c
> +++ b/drivers/hid/hid-axff.c
> @@ -154,6 +154,7 @@ static int ax_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  	error = hid_hw_open(hdev);
>  	if (error) {
>  		dev_err(&hdev->dev, "hw open failed\n");
> +		hid_hw_stop(hdev);
>  		return error;
>  	}

Good catch, applied. Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/