linux-kernel - Re: [PATCH 2/2] TTY: remove tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E1EDE96.8070700@gmail.com>
Date:	Thu, 14 Jul 2011 14:18:30 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	gregkh@...e.de, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
	Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 2/2] TTY: remove tty_locked

On 07/13/2011 12:31 PM, Jiri Slaby wrote:
> --- a/drivers/tty/tty_mutex.c
> +++ b/drivers/tty/tty_mutex.c
...
> @@ -25,10 +23,7 @@ void __lockfunc tty_lock(void)
>  {
>  	struct task_struct *task = current;

Hmm I overlooked it generates a warning:
drivers/tty/tty_mutex.c: In function ‘tty_lock’:
drivers/tty/tty_mutex.c:24:22: warning: unused variable ‘task’
drivers/tty/tty_mutex.c: In function ‘tty_unlock’:
drivers/tty/tty_mutex.c:32:22: warning: unused variable ‘task’

> -	WARN_ON(__big_tty_mutex_owner == task);
> -
>  	mutex_lock(&big_tty_mutex);
> -	__big_tty_mutex_owner = task;
>  }

I will send whole series as v2 since it is confusing enough.

thanks,
-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/