[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4E1F5E96.2060709@zytor.com>
Date: Thu, 14 Jul 2011 14:24:38 -0700
From: "H. Peter Anvin" <hpa@...or.com>
To: Yinghai Lu <yinghai@...nel.org>
CC: Tejun Heo <tj@...nel.org>, mingo@...hat.com, tglx@...utronix.de,
benh@...nel.crashing.org, davem@...emloft.net,
linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
x86@...nel.org
Subject: Re: [PATCH 2.5/13] memblock: Use __meminit[data] instead of __init[data]
On 07/14/2011 02:00 PM, Yinghai Lu wrote:
>>
>> diff --git a/include/linux/memblock.h b/include/linux/memblock.h
>> index aa5df9e..434b958 100644
>> --- a/include/linux/memblock.h
>> +++ b/include/linux/memblock.h
>> @@ -152,8 +152,8 @@ static inline unsigned long memblock_region_reserved_end_pfn(const struct memblo
>>
>>
>> #ifdef ARCH_DISCARD_MEMBLOCK
>> -#define __init_memblock __init
>> -#define __initdata_memblock __initdata
>> +#define __init_memblock __meminit
>> +#define __initdata_memblock __meminitdata
>> #else
>> #define __init_memblock
>> #define __initdata_memblock
>
> that is not good. It will keep memblock.reserved related data and
> functions after boot.
> and those data/func are not used after slab is ready.
>
>From the look of it this ranges from about 7-19K, so I'm going to take
this and we can optimize this later.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists