linux-kernel - Re: [PATCH] [RFC] perf: robustify proc and debugfs file recording

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <28585.1310602685@neuling.org>
Date:	Thu, 14 Jul 2011 10:18:05 +1000
From:	Michael Neuling <mikey@...ling.org>
To:	Sonny Rao <sonnyrao@...omium.org>
cc:	Steven Rostedt <rostedt@...dmis.org>, acme@...hat.com,
	anton@...ba.org, Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RFC] perf: robustify proc and debugfs file recording

> >>> +  if (pwrite(output_fd, &size, hdr_sz, hdr_pos) < 0)
> >>
> >> s/&size/sizep/
> >
> > Argh, I'm really messing this up... so yeah this shouldn't have worked
> > on big-endian without that fix..
> > Mikey, are you sure it worked?
> 
> Actually, I think you need to use tracepoints or this code won't be invoked=
> .
> So, please try with some tracepoints, thanks.

Yeah, with tracepoints it's broken.  

With Steven fix though it's all good on my powerpc box.

Mikey
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/