linux-kernel - Re: [PATCH] Input: pmic8xxx-keypad - fix a leak of the IRQ during init failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E1E8BB8.2060809@codeaurora.org>
Date:	Thu, 14 Jul 2011 11:54:56 +0530
From:	Anirudh Ghayal <aghayal@...eaurora.org>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org, Trilok Soni <tsoni@...eaurora.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] Input: pmic8xxx-keypad - fix a leak of the IRQ during
 init failure


On 7/14/2011 7:39 AM, Axel Lin wrote:
> Make sure we are passing the same cookie in all calls to
> request_any_context_irq() and free_irq().
>
> Signed-off-by: Axel Lin<axel.lin@...il.com>

Acked-by: Anirudh Ghayal <aghayal@...eaurora.org>

> ---
>   drivers/input/keyboard/pmic8xxx-keypad.c |    8 ++++----
>   1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/input/keyboard/pmic8xxx-keypad.c b/drivers/input/keyboard/pmic8xxx-keypad.c
> index 6229c3e..e7cc51d 100644
> --- a/drivers/input/keyboard/pmic8xxx-keypad.c
> +++ b/drivers/input/keyboard/pmic8xxx-keypad.c
> @@ -700,9 +700,9 @@ static int __devinit pmic8xxx_kp_probe(struct platform_device *pdev)
>   	return 0;
>
>   err_pmic_reg_read:
> -	free_irq(kp->key_stuck_irq, NULL);
> +	free_irq(kp->key_stuck_irq, kp);
>   err_req_stuck_irq:
> -	free_irq(kp->key_sense_irq, NULL);
> +	free_irq(kp->key_sense_irq, kp);
>   err_gpio_config:
>   err_get_irq:
>   	input_free_device(kp->input);
> @@ -717,8 +717,8 @@ static int __devexit pmic8xxx_kp_remove(struct platform_device *pdev)
>   	struct pmic8xxx_kp *kp = platform_get_drvdata(pdev);
>
>   	device_init_wakeup(&pdev->dev, 0);
> -	free_irq(kp->key_stuck_irq, NULL);
> -	free_irq(kp->key_sense_irq, NULL);
> +	free_irq(kp->key_stuck_irq, kp);
> +	free_irq(kp->key_sense_irq, kp);
>   	input_unregister_device(kp->input);
>   	kfree(kp);
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/