linux-kernel - Re: Status of MIPS on 3.0.0-rc6 kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E2032D7.9000704@broadcom.com>
Date:	Fri, 15 Jul 2011 14:30:15 +0200
From:	"Roland Vossen" <rvossen@...adcom.com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
cc:	"Jonas Gorski" <jonas.gorski@...il.com>,
	"Geert Uytterhoeven" <geert@...ux-m68k.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mips@...ux-mips.org" <linux-mips@...ux-mips.org>
Subject: Re: Status of MIPS on 3.0.0-rc6 kernel

> Please check if the appended patch helps.

It does, I am able to build a big endian MIPS kernel now. Can you notify 
me if you submit this patch ?

Thanks, Roland.

>
> Thanks,
> Rafael
>
> ---
> From: Rafael J. Wysocki<rjw@...k.pl>
> Subject: MIPS: Convert i8259.c to using syscore_ops
>
> The code in arch/mips/kernel/i8259.c still hasn't been converted to
> using struct syscore_ops instead of a sysdev for resume and shutdown.
> As a result, this code doesn't build any more after suspend, resume
> and shutdown callbacks have been removed from struct sysdev_class.
> Fix this problem by converting i8259.c to using syscore_ops.
>
> Signed-off-by: Rafael J. Wysocki<rjw@...k.pl>
> ---
>   arch/mips/kernel/i8259.c |   22 ++++++----------------
>   1 file changed, 6 insertions(+), 16 deletions(-)
>
> Index: linux-2.6/arch/mips/kernel/i8259.c
> ===================================================================
> --- linux-2.6.orig/arch/mips/kernel/i8259.c
> +++ linux-2.6/arch/mips/kernel/i8259.c
> @@ -14,7 +14,7 @@
>   #include<linux/interrupt.h>
>   #include<linux/kernel.h>
>   #include<linux/spinlock.h>
> -#include<linux/sysdev.h>
> +#include<linux/syscore_ops.h>
>   #include<linux/irq.h>
>
>   #include<asm/i8259.h>
> @@ -215,14 +215,13 @@ spurious_8259A_irq:
>   	}
>   }
>
> -static int i8259A_resume(struct sys_device *dev)
> +static void i8259A_resume(void)
>   {
>   	if (i8259A_auto_eoi>= 0)
>   		init_8259A(i8259A_auto_eoi);
> -	return 0;
>   }
>
> -static int i8259A_shutdown(struct sys_device *dev)
> +static void i8259A_shutdown(void)
>   {
>   	/* Put the i8259A into a quiescent state that
>   	 * the kernel initialization code can get it
> @@ -232,26 +231,17 @@ static int i8259A_shutdown(struct sys_de
>   		outb(0xff, PIC_MASTER_IMR);	/* mask all of 8259A-1 */
>   		outb(0xff, PIC_SLAVE_IMR);	/* mask all of 8259A-1 */
>   	}
> -	return 0;
>   }
>
> -static struct sysdev_class i8259_sysdev_class = {
> -	.name = "i8259",
> +static struct syscore_ops i8259_syscore_ops = {
>   	.resume = i8259A_resume,
>   	.shutdown = i8259A_shutdown,
>   };
>
> -static struct sys_device device_i8259A = {
> -	.id	= 0,
> -	.cls	=&i8259_sysdev_class,
> -};
> -
>   static int __init i8259A_init_sysfs(void)
>   {
> -	int error = sysdev_class_register(&i8259_sysdev_class);
> -	if (!error)
> -		error = sysdev_register(&device_i8259A);
> -	return error;
> +	register_syscore_ops(&i8259_syscore_ops);
> +	return 0;
>   }
>
>   device_initcall(i8259A_init_sysfs);
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/