linux-kernel - Re: [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAO+b5-qgrV=gfZAczxfPbGqVtv4ZD_zZHOn-BMVY9wnJytbrtw@mail.gmail.com>
Date:	Fri, 15 Jul 2011 18:10:37 +0200
From:	Bart Van Assche <bvanassche@....org>
To:	Jason Baron <jbaron@...hat.com>
Cc:	Joe Perches <joe@...ches.com>, gregkh@...e.de,
	jim.cromie@...il.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/11] dynamic_debug: use a single printk() to emit msgs

On Fri, Jul 15, 2011 at 6:04 PM, Jason Baron <jbaron@...hat.com> wrote:
> yes, but that approach uses 'KERN_CONT'. The point of patch 11/11 is to get rid
> of KERN_CONT, which is racy.

I know. What I'm trying to explain is that since patch 11/11 modifies
dynamic_emit_prefix() such that it writes its output to a buffer there
is no longer a need to write into that buffer with a single snprintf()
call. Using multiple snprintf() calls is also fine. Hence it is
possible to eliminate the two temporary arrays (tid[] and lineno[])
from dynamic_emit_prefix() without reintroducing these races.

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/