linux-kernel - Re: [PATCH 3/4] regmap: Add SPI bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 15 Jul 2011 12:30:32 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Jonathan Cameron <jic23@....ac.uk>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Greg KH <greg@...ah.com>, Jean Delvare <khali@...ux-fr.org>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Oritz <sameo@...ux.intel.com>,
	Graeme Gregory <gg@...mlogic.co.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] regmap: Add SPI bus support

On Fri, Jul 15, 2011 at 10:01:36AM +0100, Jonathan Cameron wrote:
> On 07/15/11 06:09, Mark Brown wrote:
> > On Thu, Jul 14, 2011 at 11:04:27PM -0600, Grant Likely wrote:
> >> On Thu, Jul 14, 2011 at 10:39 PM, Mark Brown
> >> <broonie@...nsource.wolfsonmicro.com> wrote:
> > 
> > [Regmap API I2C bus code.]
> >>> There was a bit about this in the cover mail - it's the interace
> >>> stability issue again, the plan is to move them once we're more
> >>> confident that the interface used will stay stable.
> > 
> >> I've got no problem with churn in drivers/spi, and I'm fine to have
> >> changes in drivers/spi merged via other trees if it means the code is
> >> in the logical place.
> > 
> > Can I add an ack from you for that?  If/when it does get merged I'd
> > appreciate it if you pushed any code to me for review.
> > 
> >>>>       struct spi_transfer t[2] = { {.tx_buf = reg, .len = reg_len},
> >>>>                                    {.tx_buf = val, .len = val_len}};
> > 
> >>>> Then the memset() and t[0]/t[1] lines can all be culled.
> > 
> >>> That does the init to zero?
> > 
> >> You might want to double check, but I believe it gets implemented as a
> >> memcpy of a static initializer.
> > 
> > Hrm, given that neither of us is 100% sure I think it's safer to leave
> > it written out long hand and avoid confusing anyone else.
> 
> It does the init to zero. The relevant bit of the spec is designated initializers.
> 
> See c99 spec (draft here as I'm not paying for it ;) WG14/N1124
> 6.7.8 

Okay, good.  I would prefer the initializer form.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/