[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110715225707.GE17254@google.com>
Date: Fri, 15 Jul 2011 15:57:07 -0700
From: Mandeep Singh Baines <msb@...omium.org>
To: Andrew Morton <akpm@...ux-foundation.org>
Cc: Mandeep Singh Baines <msb@...omium.org>,
Huang Ying <ying.huang@...el.com>,
Andi Kleen <ak@...ux.intel.com>,
Hugh Dickins <hughd@...omium.org>,
Olaf Hering <olaf@...fle.de>,
Jesse Barnes <jbarnes@...tuousgeek.org>,
Dave Airlie <airlied@...il.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] panic, vt: do not force oops output when panic_timeout
< 0
Andrew Morton (akpm@...ux-foundation.org) wrote:
> On Wed, 22 Jun 2011 15:30:39 -0700
> Mandeep Singh Baines <msb@...omium.org> wrote:
>
> > Mandeep Singh Baines (msb@...omium.org) wrote:
> > > Avoid risk (of screen_unblank) and wasted cycles unblanking if
> > > you intend to reboot immediately.
> > >
> >
> > The original patch doesn't work. It worked fine when I tested with
> > a serial port. When I disabled the serial out, my machine started to
> > get wedged on a panic. I guess screen_unblank was in bust_spinlocks
> > for a reason. It probably bust some spin_locks somewhere.
> >
> > Below is a replacement for this patch which calls screen_unblank but
> > does not force output when the panic timeout is negative (no wait).
> >
> > -- >8 -- (snip)
> >
> > Don't force output if you intend to reboot immediately.
> >
> > This patch depends on:
> >
> > http://lkml.kernel.org/r/1308612129-12488-1-git-send-email-msb@chromium.org
>
> Please fold this into that and resend the patch series. Please add
> the needed update to Documentation/kernel-parameters.txt.
Done:
http://lkml.kernel.org/r/1310770401-10739-1-git-send-email-msb@chromium.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists