linux-kernel - Re: linux-next: build failure after merge of the jdelvare-hwmon tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Jul 2011 17:33:41 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Stephen Rothwell <sfr@...b.auug.org.au>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: linux-next: build failure after merge of the jdelvare-hwmon
 tree

Hi Stephen,

On Sat, 16 Jul 2011 17:06:01 +1000, Stephen Rothwell wrote:
> After merging the jdelvare-hwmon tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
> 
> drivers/hwmon/max1111.c: In function 'max1111_remove':
> drivers/hwmon/max1111.c:213:2: error: incompatible type for argument 1 of 'mutex_destroy'
> include/linux/mutex-debug.h:21:13: note: expected 'struct mutex *' but argument is of type 'struct mutex'
> 
> Caused by commit d2fbca2996a8 ("hwmon: (max1111) Fix race condition
> causing NULL pointer exception").  Missing '&'?

Oh, right, good catch. It went unnoticed so far because mutex_destroy
resolves to nothing unless CONFIG_DEBUG_MUTEXES=y. I plan to submit a
patch turning the empty implementation of mutex_destroy to an inline
function, so that this kind of problem gets caught earlier.

> I have used the jdelvare-hwmon tree from next-20110707 for today.

Problem is fixed now, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/