linux-kernel - Re: [PATCH] tpm: Fix compilation warning when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110718091624.bd262188190c5d7a05416b99@canb.auug.org.au>
Date:	Mon, 18 Jul 2011 09:16:24 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Stefan Berger <stefanb@...ux.vnet.ibm.com>
Cc:	rdunlap@...otime.net, Rajiv Andrade <srajiv@...ux.vnet.ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	James Morris <jmorris@...ei.org>, linux-next@...r.kernel.org
Subject: Re: [PATCH] tpm: Fix compilation warning when CONFIG_PNP is not
 defined

Hi Stefan,

On Sun, 17 Jul 2011 07:55:58 -0400 Stefan Berger <stefanb@...ux.vnet.ibm.com> wrote:
>
> The is_itpm() function is only accessed from a block surrounded by
> #ifdef CONFIG_PNP. Therefore, also surround it with #ifdef CONFIG_PNP
                ^^^

> --- linux-2.6.orig/drivers/char/tpm/tpm_tis.c
> +++ linux-2.6/drivers/char/tpm/tpm_tis.c
> @@ -80,7 +80,7 @@ enum tis_defaults {
>  static LIST_HEAD(tis_chips);
>  static DEFINE_SPINLOCK(tis_lock);
>  
> -#ifdef CONFIG_ACPI
> +#ifdef CONFIG_PNPN
                 ^^^^
Is this a typo?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped