linux-kernel - Re: [PATCH] Summary: Fixed all the indents and other errors in IEEE11h.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 15:36:48 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Toon Schoenmakers <nighteyes1993@...il.com>
Cc:	gregkh@...e.de, caratorn@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Summary: Fixed all the indents and other errors in
 IEEE11h.c

On Sun, Jul 17, 2011 at 01:38:29AM +0200, Toon Schoenmakers wrote:

> +	uNumOfEIDs = ((uLength - offsetof(WLAN_FRAME_MSRREQ,
> +			sMSRReqEIDs))/
> +			(sizeof(WLAN_IE_MEASURE_REQ)));

It would be better to write this in C instead of Lisp:

	uNumOfEIDs = (uLength - offsetof(WLAN_FRAME_MSGREQ, sMSRReqEIDS)) /
			sizeof(WLAN_EI_MEASURE_REQ);

The other advantage of that is that the call to offsetof() is now
all together on one line.

> +	pTxPacket->p80211Header = (PUWLAN_80211HDR)((unsigned char *)pTxPacket +
> +sizeof(STxMgmtPacket));
> +
> +	pFrame = (PWLAN_FRAME_TPCREP)((unsigned char *)pTxPacket +
> +sizeof(STxMgmtPacket));
> +

Don't do that.

> +	pFrame->Header.wFrameCtl = (WLAN_SET_FC_FTYPE(WLAN_FTYPE_MGMT) |
> +				WLAN_SET_FC_FSTYPE(WLAN_FSTYPE_ACTION)
> +				);

The close parenthesis can fit on the end of the other line.  In fact
the paren is not needed at all.  Why is the second line aligned where
you have it?  The WLAN_SET_FC_FSTYPE() isn't aligned with anything.

Take a another look through the patch and you'll find a bunch of
similar issues.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/