linux-kernel - RE: [PATCH -next] watchdog: hpwdt depends on PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <183C1D5A376DE343AA8F94FC2A1EC1497D7ADD1EF0@GVW1091EXB.americas.hpqcorp.net>
Date:	Mon, 18 Jul 2011 17:40:53 +0100
From:	"Mingarelli, Thomas" <Thomas.Mingarelli@...com>
To:	Randy Dunlap <rdunlap@...otime.net>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Wim Van Sebroeck <wim@...ana.be>
CC:	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>
Subject: RE: [PATCH -next] watchdog: hpwdt depends on PCI

Ack'd by Tom Mingarelli.

-----Original Message-----
From: Randy Dunlap [mailto:rdunlap@...otime.net] 
Sent: Saturday, July 16, 2011 2:26 PM
To: Stephen Rothwell; Wim Van Sebroeck
Cc: linux-next@...r.kernel.org; LKML; Mingarelli, Thomas; akpm
Subject: [PATCH -next] watchdog: hpwdt depends on PCI

From: Randy Dunlap <rdunlap@...otime.net>

hpwdt is a PCI driver so it should depend on PCI.
Fixes these build errors:

drivers/watchdog/hpwdt.c:762: error: implicit declaration of function 'pci_iomap'
drivers/watchdog/hpwdt.c:762: warning: assignment makes pointer from integer without a cast
drivers/watchdog/hpwdt.c:797: error: implicit declaration of function 'pci_iounmap'

Signed-off-by: Randy Dunlap <rdunlap@...otime.net>
Cc: Wim Van Sebroeck <wim@...ana.be>
Cc: Thomas Mingarelli <thomas.mingarelli@...com>
---
 drivers/watchdog/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-next-20110716.orig/drivers/watchdog/Kconfig
+++ linux-next-20110716/drivers/watchdog/Kconfig
@@ -619,7 +619,7 @@ config IT87_WDT
 
 config HP_WATCHDOG
 	tristate "HP ProLiant iLO2+ Hardware Watchdog Timer"
-	depends on X86
+	depends on X86 && PCI
 	default m
 	help
 	  A software monitoring watchdog and NMI sourcing driver. This driver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/