linux-kernel - Re: [PATCH] kconfig/nconf: remove useless conditionnal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 14:11:58 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	linux-kbuild@...r.kernel.org, Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, Arnaud Lacombe <lacombar@...il.com>,
	Nir Tzachar <nir.tzachar@...il.com>
Subject: Re: [PATCH] kconfig/nconf: remove useless conditionnal

Hi,

On Sun, Jul 10, 2011 at 3:27 AM, Arnaud Lacombe <lacombar@...il.com> wrote:
> After the test
>
>        if (!submenu || ...)
>                continue;
>
> the variable `submenu' can _not_ be NULL, so do not test for this situation.
>
> Cc: Nir Tzachar <nir.tzachar@...il.com>
> Signed-off-by: Arnaud Lacombe <lacombar@...il.com>
> ---
>  scripts/kconfig/nconf.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index eb9e49d..6b189c8 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -1155,10 +1155,7 @@ static void conf(struct menu *menu)
>                active_menu = (struct menu *)item_data();
>                if (!submenu || !menu_is_visible(submenu))
>                        continue;
> -               if (submenu)
> -                       sym = submenu->sym;
> -               else
> -                       sym = NULL;
> +               sym = submenu->sym;
>
>                switch (res) {
>                case ' ':
Michal, ping ?

 - Arnaud

> --
> 1.7.3.4.574.g608b.dirty
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/