linux-kernel - Re: [PATCH] netfilter: add per-namespace logging to nfnetlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Jul 2011 22:28:25 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Rainer Weikusat <rweikusat@...ileactivedefense.com>
cc:	David Miller <davem@...emloft.net>, adobriyan@...il.com,
	kaber@...sh.net, netfilter-devel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netfilter: add per-namespace logging to
 nfnetlink_log.c


On Monday 2011-07-18 22:17, Rainer Weikusat wrote:
>David Miller <davem@...emloft.net> writes:
>>
>>> [rw@...phire]~/work/linux-2-6/net/netfilter $find -name '*.c' | xargs grep '^#ifdef' | wc -l
>>> 239
>>
>> You've shown nothing.  Showing exceptions does not prove that the
>> general effort has been to keep ifdef crap out of *.c files.
>
>I've 'shown' that the networking code contains a fair amount of
>#ifdefs in .c files. Consequently, 'we did it without' is wrong. At
>best, 'we would like to do without in future' seems justified.

Your count of ifdefs is just telling that we use ifdef, not how we
use it.

There is a difference between #ifdefs sprinkled inside a function,
and #ifdefs around functions or larger groups where possible,
feasible and optically preferable (cf. security.h, xt_TEE.c).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/