linux-kernel - Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to devio.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <73f3a41d26b2e3462c93c3c3b85706ca.squirrel@www.codeaurora.org>
Date:	Tue, 19 Jul 2011 03:36:05 -0700 (PDT)
From:	"Amit Blay" <ablay@...eaurora.org>
To:	"Oliver Neukum" <oneukum@...e.de>
Cc:	"Amit Blay" <ablay@...eaurora.org>,
	"Sarah Sharp" <sarah.a.sharp@...ux.intel.com>,
	"Tatyana Brokhman" <tlinder@...eaurora.org>, greg@...ah.com,
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	balbi@...com, "Amit Blay" <ablay@...lcomm.com>,
	"open list" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH/RFC 5/5] usb: Add support for streams alloc/dealloc to 
     devio.c

Hi Oliver,

>> >> 1. Interface number [IN]
>> >> 2. Bitmap indicating which EP to allocate streams for [IN]
>> >
>> > If this is a bitmap,
>> >
>> >> 3. Number of streams to allocate, one number [IN}
>> >> 4. Number of streams actually allocated, one number  [OUT]
>> >
>> > how can those be scalars?
>> >
>>
>> The bitmap only indicates which EP the user space requests to allocate
>> streams for. The actual number is taken from #3.
>
> Exactly. If you specify EP with a bitmap, what do you do if multiple bits
> are set in the map?
>

The user space can pass multiple EPs to allocate streams for. This is
aligned with the HCD API which expects an array of EPs and number of
streams to allocate. Please have a look in xhci.c.

I suggest to pass a bitmap from user space to represent the list of EPs.
An alternative is to pass an array, but I didn't find any real advantage
for this.

Thanks,
Amit.

 --
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/