linux-kernel - Re: [Xen-devel] Re: [PATCH resubmit] xen-blkfront: Don't send closing notification to backend in blkfront

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110719132149.GA3178@dumpdata.com>
Date:	Tue, 19 Jul 2011 09:21:49 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Joe Jin <joe.jin@...cle.com>
Cc:	Ian Campbell <Ian.Campbell@...citrix.com>,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>,
	Kurt C Hackel <KURT.HACKEL@...cle.com>,
	Greg Marsden <greg.marsden@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"annie.li@...cle.com" <annie.li@...cle.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	Jens Axboe <jaxboe@...ionio.com>,
	"stable@...nel.org" <stable@...nel.org>,
	Daniel Stodden <Daniel.Stodden@...rix.com>
Subject: Re: [Xen-devel] Re: [PATCH resubmit] xen-blkfront: Don't send
 closing notification to backend in blkfront_closing()

On Fri, Jul 15, 2011 at 03:58:50PM +0800, Joe Jin wrote:
> On 07/14/11 17:12, Ian Campbell wrote:
> > On Thu, 2011-07-14 at 09:55 +0100, Joe Jin wrote:
> >> On 07/14/11 16:13, Ian Campbell wrote:
> >>> On Wed, 2011-07-13 at 01:47 +0100, Joe Jin wrote:
> > 
> >>>
> >>> I'm wondering if we might not be better off deferring the disconnect on
> >>> the backend side until the frontend enters XenbusStateClosed instead of
> >>> doing it in closing.
> >>
> >> Yes this fix from backend side works too, also this looks reasonable than 
> >> fix in frontend.
> > 
> > I guess there is either a missing "more" or "less" in that sentence ;-)
> > 
> > The nice thing about a backend fix is that you don't need to go round
> > propagating the fix into distros etc and updating existing deployed
> > guests (not to mention non-Linux frontends).
> 
> Indeed ;)
> 
> > 
> > I actually thought blkback had something like this already in older
> > "classic" Xen kernels but it seems like the patch never made it out of
> > the XCP patch queue :-(. See
> > http://xenbits.xen.org/hg/XCP/linux-2.6.32.pq.hg/file/tip/CA-7672-blkback-shutdown.patch
> > (which appears to also incorporate a toolstack directed graceful
> > shutdown of some sort as well as deferring the device close).
> > 
> > Daniel, do you know of any plans to extricate that stuff from the XCP
> > patch queue for upstream? Are there any other patches (e.g. incremental
> > fixes) in that pq which should go along with it?
> 
> Looking forward push this patch to upstream!

Not sure if Daniel is going to get to this. Joe, and chance you could
take a look at it and up-port in the 3.0 kernel?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/