linux-kernel - Re: [PATCH] gpio/mxc/mxs: fix build error introduced by the reanming of irq_gc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110719152323.GA6628@pengutronix.de>
Date:	Tue, 19 Jul 2011 17:23:23 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Shawn Guo <shawn.guo@...escale.com>
Cc:	Sergei Shtylyov <sshtylyov@...sta.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	Shawn Guo <shawn.guo@...aro.org>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, patches@...aro.org
Subject: Re: [PATCH] gpio/mxc/mxs: fix build error introduced by the reanming
 of irq_gc_ack()

Hello Shawn,

> > >  	ct = gc->chip_types;
> > >-	ct->chip.irq_ack = irq_gc_ack,
> > >+	ct->chip.irq_ack = irq_gc_ack_set_bit,
> > 
> >    There should be semicolon rathern than comma at the end.
> > 
> Thanks, Sergei.  I'm pretty surprised that gcc did not help me there.
> > >  	ct->chip.irq_mask = irq_gc_mask_clr_bit;
That's because using a comma is valid C, too.
It just assigns ct->chip.irq_ack as a side effect of the
expression

	ct->chip.irq_ack = irq_gc_ack_set_bit, ct->chip.irq_unmask = irq_gc_mask_set_bit;

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/