linux-kernel - Re: [PATCH 1/2] serial:blackfin: Correct coding style in bfin serial driver.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1311089315.2286.157.camel@Joe-Laptop>
Date:	Tue, 19 Jul 2011 08:28:35 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sonic Zhang <sonic.adi@...il.com>
Cc:	Alan Cox <alan@...ux.intel.com>, linux-serial@...r.kernel.org,
	linux-kernel@...r.kernel.org, Sonic Zhang <sonic.zhang@...log.com>
Subject: Re: [PATCH 1/2] serial:blackfin: Correct coding style in bfin
 serial driver.

On Tue, 2011-07-19 at 18:09 +0800, Sonic Zhang wrote:
> From: Sonic Zhang <sonic.zhang@...log.com>
[]
> @@ -1091,10 +1090,18 @@ bfin_serial_console_get_options(struct bfin_serial_port *uart, int *baud,
>  				*parity = 'o';
>  		}
>  		switch (lcr & 0x03) {
> -			case 0:	*bits = 5; break;
> -			case 1:	*bits = 6; break;
> -			case 2:	*bits = 7; break;
> -			case 3:	*bits = 8; break;
> +		case 0:
> +			*bits = 5;
> +			break;
> +		case 1:
> +			*bits = 6;
> +			break;
> +		case 2:
> +			*bits = 7;
> +			break;
> +		case 3:
> +			*bits = 8;
> +			break;
>  		}

Maybe just:
	*bits = 5 + (lcr & 3);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/