linux-kernel - Re: [PATCH 3/4] regmap: Add SPI bus support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110719215120.GS6848@ponder.secretlab.ca>
Date:	Tue, 19 Jul 2011 15:51:20 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Greg KH <greg@...ah.com>, Grant Likely <grant@...retlab.ca>,
	Jean Delvare <khali@...ux-fr.org>,
	Ben Dooks <ben-linux@...ff.org>,
	Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...com>,
	Samuel Oritz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] regmap: Add SPI bus support

On Mon, Jul 18, 2011 at 07:07:42PM +0900, Mark Brown wrote:
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> Acked-by: Liam Girdwood <lrg@...com>
> Acked-by: Wolfram Sang <w.sang@...gutronix.de>

One comment below, but otherwise:

Acked-by: Grant Likely <grant.likely@...retlab.ca>

on the whole series.
> diff --git a/include/linux/regmap.h b/include/linux/regmap.h
> index e509bac..c549632 100644
> --- a/include/linux/regmap.h
> +++ b/include/linux/regmap.h
> @@ -61,6 +61,9 @@ struct regmap *regmap_init(struct device *dev,
>  			   const struct regmap_config *config);
>  struct regmap *regmap_init_i2c(struct device *dev,
>  			       const struct regmap_config *config);
> +struct regmap *regmap_init_spi(struct device *dev,
> +			       const struct regmap_config *config);
> +

regmap_init_i2c/spi should take an i2c_client and spi_device pointer
respectively so it can be type checked.

>  void regmap_exit(struct regmap *map);
>  int regmap_write(struct regmap *map, unsigned int reg, unsigned int val);
>  int regmap_raw_write(struct regmap *map, unsigned int reg,
> -- 
> 1.7.5.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/