linux-kernel - RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049EBDED2A@HQMAIL01.nvidia.com>
Date:	Tue, 19 Jul 2011 16:04:22 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Andrew Chew <AChew@...dia.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"olof@...om.net" <olof@...om.net>,
	Dan Willemsen <dwillemsen@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Venkat Moganty <vmoganty@...dia.com>
CC:	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-arm-kernel@...r.kernel.org" <linux-arm-kernel@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Chew <AChew@...dia.com>
Subject: RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard.

achew@...dia.com wrote at Tuesday, July 19, 2011 4:47 PM:
> From: Andrew Chew <achew@...dia.com>
> 
> Signed-off-by: Andrew Chew <achew@...dia.com>

Removing status="disabled" from tegra20.dtsi makes this patch obsolete.

Although that said, since many of the USB properties are board-specific
and determined by system characterization, they aren't generally
applicable to all Tegra devices. As such, should those values be moved
into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify
the default values that the driver currently uses if not supplied with
platform data though... I think the Seaboard values are the defaults,
which still would make this patch obsolete.

> ---
>  arch/arm/boot/dts/tegra-seaboard.dts |   12 ++++++++++++
>  1 files changed, 12 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/tegra-seaboard.dts b/arch/arm/boot/dts/tegra-seaboard.dts
> index 5a99b4c..c5a1b71 100644
> --- a/arch/arm/boot/dts/tegra-seaboard.dts
> +++ b/arch/arm/boot/dts/tegra-seaboard.dts
> @@ -31,4 +31,16 @@
>  	sdhci@...00600 {
>  		status = "ok";
>  	};
> +
> +	ehci@...00000 {
> +		status = "ok";
> +	};
> +
> +	ehci@...04000 {
> +		status = "ok";
> +	};
> +
> +	ehci@...08000 {
> +		status = "ok";
> +	};
>  };
> --
> 1.7.6

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/