lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 19 Jul 2011 16:50:53 -0700 From: Andrew Chew <AChew@...dia.com> To: Stephen Warren <swarren@...dia.com>, "grant.likely@...retlab.ca" <grant.likely@...retlab.ca>, "olof@...om.net" <olof@...om.net>, Dan Willemsen <dwillemsen@...dia.com>, Rhyland Klein <rklein@...dia.com>, Venkat Moganty <vmoganty@...dia.com> CC: "devicetree-discuss@...ts.ozlabs.org" <devicetree-discuss@...ts.ozlabs.org>, "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>, "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 3/3] dt: tegra20: Add ehci nodes to Seaboard. > Although that said, since many of the USB properties are > board-specific > and determined by system characterization, they aren't generally > applicable to all Tegra devices. As such, should those values be moved > into tegra-seaboard.dts instead? Perhaps tegra20.dtsi should specify > the default values that the driver currently uses if not supplied with > platform data though... I think the Seaboard values are the defaults, > which still would make this patch obsolete. Turns out the ones I put in tegra20.dtsi are NOT the defaults. The defaults are in arch/arm/mach-tegra/usb_phy.c, contained in "utmip_defaults[]". I think I'm going to put those utmip_defaults[] stuff into tegra20.dtsi, and override them in tegra-seaboard.dts. How's that sound? And since there are defaults specified in tegra20.dtsi, does it really make sense to also have default values assigned in ehci-tegra.c (for when a property is not present)? I worry that the information is now duplicated. If those properties aren't present, then someone's mucked with the tegra20.dtsi ehci properties.-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists