linux-kernel - Re: [PATCH 2/2] scsi: target: remove custom hex2bin() implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1311052281.16756.22.camel@haakon2.linux-iscsi.org>
Date:	Mon, 18 Jul 2011 22:11:21 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
	target-devel <target-devel@...r.kernel.org>
Subject: Re: [PATCH 2/2] scsi: target: remove custom hex2bin()
	implementation

On Mon, 2011-07-18 at 11:27 +0300, Andy Shevchenko wrote:
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: "Nicholas A. Bellinger" <nab@...ux-iscsi.org>
> ---
>  drivers/target/target_core_cdb.c        |   16 ++++------------
>  drivers/target/target_core_fabric_lib.c |   17 +++++++----------
>  drivers/target/target_core_transport.c  |   28 ----------------------------
>  include/target/target_core_transport.h  |    1 -
>  4 files changed, 11 insertions(+), 51 deletions(-)
> 

Good catch to use proper include/linux/kernel.org:hex2bin() usage
instead of the custom code.

Committed as e270af8 with some minor changes to drop DEV_T10_WWN() macro
usage in favor of direct dereference following v4.1 style.

Thanks!

--nab


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/