linux-kernel - RE: [PATCH] davinci: fix DM365 EVM video input mux bits

Open Source and information security mailing list archives

Message-ID: <B85A65D85D7EB246BE421B3FB0FBB593024BCEF73E@dbde02.ent.ti.com>
Date:	Tue, 19 Jul 2011 10:59:49 +0530
From:	"Hadli, Manjunath" <manjunath.hadli@...com>
To:	"'Jon Povey'" <jon.povey@...elogic.co.uk>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"Nori, Sekhar" <nsekhar@...com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] davinci: fix DM365 EVM video input mux bits

Jon,

The fix looks correct. As a part of a different implementation which will go soon upstream, this has been taken care of, where we have used macros 
CPLD_VIDEO_INPUT_MUX_TVP7002    0x1
CPLD_VIDEO_INPUT_MUX_IMAGER     0x2

So, if you can do the same, it will look better.

Thanks,
-Manju

On Tue, Jul 19, 2011 at 09:00:11, Jon Povey wrote:
> Video input mux settings for tvp7002 and imager inputs were swapped.
> Comment was correct.
> 
> Tested on EVM with tvp7002 input.
> 
> Signed-off-by: Jon Povey <jon.povey@...elogic.co.uk>
> ---
> As a bugfix maybe this should try to get into 3.0?
> 
>  arch/arm/mach-davinci/board-dm365-evm.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-davinci/board-dm365-evm.c b/arch/arm/mach-davinci/board-dm365-evm.c
> index c67f684..09a87e6 100644
> --- a/arch/arm/mach-davinci/board-dm365-evm.c
> +++ b/arch/arm/mach-davinci/board-dm365-evm.c
> @@ -520,7 +520,7 @@ fail:
>  	 */
>  	if (have_imager()) {
>  		label = "HD imager";
> -		mux |= 1;
> +		mux |= 2;
>  
>  		/* externally mux MMC1/ENET/AIC33 to imager */
>  		mux |= BIT(6) | BIT(5) | BIT(3);
> @@ -540,7 +540,7 @@ fail:
>  		resets &= ~BIT(1);
>  
>  		if (have_tvp7002()) {
> -			mux |= 2;
> +			mux |= 1;
>  			resets &= ~BIT(2);
>  			label = "tvp7002 HD";
>  		} else {
> --
> 1.6.3.3
> 
> _______________________________________________
> Davinci-linux-open-source mailing list
> Davinci-linux-open-source@...ux.davincidsp.com
> http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives