| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110719062559.GG4010@shale.localdomain> Date: Tue, 19 Jul 2011 09:25:59 +0300 From: Dan Carpenter <error27@...il.com> To: Ryan Mallon <rmallon@...il.com> Cc: Ravishankar <ravishankarkm32@...il.com>, devel@...verdev.osuosl.org, gregkh@...e.de, linux-kernel@...r.kernel.org, Ravishankar <ravi.shankar@...enturtles.in> Subject: Re: [PATCH 1/2 v3] Staging: comedi: fix printk() issue in adv_pci1710.c On Tue, Jul 19, 2011 at 04:15:51PM +1000, Ryan Mallon wrote: > On 19/07/11 16:12, Dan Carpenter wrote: > >On Tue, Jul 19, 2011 at 04:07:27PM +1000, Ryan Mallon wrote: > >>This still isn't correct. The initial printk (KERN_INFO above) has > >>no trailing newline. Here you are almost doing it correctly, except > >>that you are adding an extra newline. This error message will look > >>like this: > >> > >>comedi0: adv_pci1710: > >>comedi0: adv_pci1710: Allocation failed > >> > >Actually kmalloc() prints an message with a stack trace on failure as > >well so that would go in the middle, just before the first newline. > > > > Thanks. Didn't know that. Is that a KConfig option or by default? By default, unless you call kmalloc() with __GFP_NOWARN. The warning is in warn_alloc_failed(). regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists