[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAM_iQpU4OXFkPc0sZfwEf27mDyd9aNOptH6BBVkiSd8Y-cVTeA@mail.gmail.com>
Date: Tue, 19 Jul 2011 14:45:19 +0800
From: Américo Wang <xiyou.wangcong@...il.com>
To: Arnaud Lacombe <lacombar@...il.com>
Cc: Michal Marek <mmarek@...e.cz>,
Andrew Morton <akpm@...ux-foundation.org>,
linux-kernel@...r.kernel.org
Subject: Re: [Patch] fix a headers_check warning in include/linux/kernel.h
On Tue, Jul 19, 2011 at 12:51 AM, Arnaud Lacombe <lacombar@...il.com> wrote:
> Hi,
>
> On Sun, Jul 17, 2011 at 3:46 AM, Américo Wang <xiyou.wangcong@...il.com> wrote:
>> This fixes the warning:
>>
>> linux-2.6/usr/include/linux/kernel.h:65: userspace cannot reference
>> function or variable defined in the kernel
>>
>> As Michal noted, BUILD_BUG_ON stuffs should be moved
>> under #ifdef __KERNEL__.
>>
>> Signed-off-by: WANG Cong <xiyou.wangcong@...il.com>
>>
> Why not all the other macros below the BUILD_BUG_ON stuff ? E.g. do we
> want to export __FUNCTION__ ? NUMA_BUILD ? COMPACTION_BUILD ?
> REBUILD_DUE_TO_FTRACE_MCOUNT_RECORD ?
>
Right, certainly we should move them too.
I saw Andrew already merged a delta patch. Thanks to both of you!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists