linux-kernel - Re: [patch]drivers:net:Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2011 14:10:19 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	wangyanqing <udknight@...il.com>
Cc:	davem@...emloft.net, linux-kernel@...r.kernel.org
Subject: Re: [patch]drivers:net:Kconfig

Le mercredi 20 juillet 2011 à 20:05 +0800, wangyanqing a écrit :
> Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY,
>  so maybe we should add a dependence on it.Or at least we should add
>  notice in the help txt.
> 
> Signed-off-by: wang yanqing <udknight@...il.com>
> ---
>  drivers/net/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 93359fa..c2607cd 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2353,7 +2353,7 @@ config VIA_VELOCITY
>  
>  config TIGON3
>  	tristate "Broadcom Tigon3 support"
> -	depends on PCI
> +	depends on PCI && BROADCOM_PHY
>  	select PHYLIB
>  	help
>  	  This driver supports Broadcom Tigon3 based gigabit Ethernet cards.

Hmm.

When do you plan to answer to my previous question ?

I said :

Thats strange.

Here I have a (running) tg3 adapter, but

$ zgrep BROADCOM /proc/config.gz
# CONFIG_BROADCOM_PHY is not set

Could you elaborate ?



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/