linux-kernel - Re: [PATCH linux-next-20110718] Fix build error at mm/slab.c .

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1107201616120.3528@tiger>
Date:	Wed, 20 Jul 2011 16:16:25 +0300 (EEST)
From:	Pekka Enberg <penberg@...nel.org>
To:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
cc:	cl@...ux.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next-20110718] Fix build error at mm/slab.c .

On Wed, 20 Jul 2011, Tetsuo Handa wrote:

> ARCH_SLAB_MINALIGN might be defined as
>
>  #define ARCH_SLAB_MINALIGN __alignof__(unsigned long long)
>
> but gcc 3.3 cannot understand
>
>  #if __alignof__(unsigned long long)
>
> line.
>
>  CC      mm/slab.o
> mm/slab.c:3156:5: warning: "__alignof__" is not defined
> mm/slab.c:3156:5: missing binary operator before token "("
> make[1]: *** [mm/slab.o] Error 1
> make: *** [mm] Error 2
>
> Use "if (ARCH_SLAB_MINALIGN)" rather than "#if ARCH_SLAB_MINALIGN".
>
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> ---
> mm/slab.c |    5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> --- linux-3.0-next.orig/mm/slab.c
> +++ linux-3.0-next/mm/slab.c
> @@ -3153,12 +3153,9 @@ static void *cache_alloc_debugcheck_afte
> 	objp += obj_offset(cachep);
> 	if (cachep->ctor && cachep->flags & SLAB_POISON)
> 		cachep->ctor(objp);
> -#if ARCH_SLAB_MINALIGN
> -	if ((u32)objp & (ARCH_SLAB_MINALIGN-1)) {
> +	if (ARCH_SLAB_MINALIGN && ((u32)objp & (ARCH_SLAB_MINALIGN-1)))
> 		printk(KERN_ERR "0x%p: not aligned to ARCH_SLAB_MINALIGN=%d\n",
> 		       objp, ARCH_SLAB_MINALIGN);
> -	}
> -#endif
> 	return objp;

Looks good to me. Christoph?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/