linux-kernel - Re: [PATCH v2] Track hard and soft "short lockups" or "stalls."

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2011 11:41:24 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	ZAK Magnus <zakmagnus@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Track hard and soft "short lockups" or "stalls."

On Mon, Jul 18, 2011 at 02:45:55PM -0700, ZAK Magnus wrote:
> Okay, great. I'm eager to hear anything you may discover, good or bad. By
> the way, would you mind sharing a bit about how you do your testing for
> this?

Sorry for getting back to you late, busy week.

Most of the testing I do is from the lkdtm module

modprobe lkdtm
mount -t debugfs none /sys/kernel/debug
cd /sys/kernel/debug/provoke-crashing/
service cpuspeed stop
echo HARDLOCKUP > DIRECT #or SOFTLOCKUP or HUNG_TASK

I then count to 10 seconds to make sure the timer is within reason.

So I did the above test and noticed the panic looked funny because it spit
out the 

new worst hard stall seen on CPU#0: 3 interrupts missed

and then 

new worst hard stall seen on CPU#0: 4 interrupts missed

and then finally the HARDLOCKUP message

I am not sure that is what we want as it confuses people as to where the
panic really is.

What if you moved the 'update_hardstall()' to just underneath the zero'ing
out of the hrtimer_interrupts_missed?  This only then prints out the
interrupts missed line when you know the end point.  And avoids printing
it all together in the case of a true HARDLOCKUP.  Like the patch below

diff --git a/kernel/watchdog.c b/kernel/watchdog.c
index 7d37cc2..ba41a74 100644
--- a/kernel/watchdog.c
+++ b/kernel/watchdog.c
@@ -238,13 +238,14 @@ static int is_hardlockup(int this_cpu)
 
 	if (hrint_saved == hrint)
 		ints_missed = per_cpu(hrtimer_interrupts_missed, this_cpu)++;
-	else
+	else {
 		__this_cpu_write(hrtimer_interrupts_missed, 0);
+		update_hardstall(ints_missed, this_cpu);
+	}
 
 	if (ints_missed >= hardlockup_thresh)
 		return 1;
 
-	update_hardstall(ints_missed, this_cpu);
 	return 0;
 }
 #endif

The softlockup case probably needs the same.

Thoughts?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/