linux-kernel - Re: linux-next: Tree for July 20 (qlcnic)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0E5EAE44-204C-4F4D-926C-F4D973B0CDB1@qlogic.com>
Date:	Wed, 20 Jul 2011 11:10:18 -0700
From:	Anirban Chakraborty <anirban.chakraborty@...gic.com>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	netdev <netdev@...r.kernel.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Linux Driver <Linux-Driver@...gic.com>,
	David Lamparter <equinox@...c24.net>
Subject: Re: linux-next: Tree for July 20 (qlcnic)


On Jul 20, 2011, at 9:19 AM, Randy Dunlap wrote:

> On Wed, 20 Jul 2011 18:00:41 +1000 Stephen Rothwell wrote:
> 
>> Hi all,
> 
> When CONFIG_VLAN_8021Q is not enabled:
> 
> drivers/net/qlcnic/qlcnic_main.c:4207: error: 'struct net_device' has no member named 'vlgrp'

This is caused by the following commit:

commit 69ecca86da4890c13a5e29c51b4ac76a1a8a62c9                                                      
Refs: v3.0-rc7-1265-g69ecca8                                                                         
Author:     David Lamparter <equinox@...c24.net>                                                     
AuthorDate: Sun Jul 17 08:53:12 2011 +0000                                                           
Commit:     David S. Miller <davem@...emloft.net>                                                    
CommitDate: Sun Jul 17 12:33:22 2011 -0700                                                           
                                                                                                     
    net: vlan, qlcnic: make vlan_find_dev private                                                    
                                                                                                     
    there is only one user of vlan_find_dev outside of the actual vlan code:                         
    qlcnic uses it to iterate over some VLANs it knows.                                              
                                                                                                     
    let's just make vlan_find_dev private to the VLAN code and have the                              
    iteration in qlcnic be a bit more direct. (a few rcu dereferences less                           
    too)                                                                                             
                                                                                                     
    Signed-off-by: David Lamparter <equinox@...c24.net>                                              
    Cc: Patrick McHardy <kaber@...sh.net>                                                            
    Cc: Amit Kumar Salecha <amit.salecha@...gic.com>                                                 
    Cc: Anirban Chakraborty <anirban.chakraborty@...gic.com>                                         
    Cc: linux-driver@...gic.com                                                                      
    Signed-off-by: David S. Miller <davem@...emloft.net>                                             


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/