linux-kernel - Re: [PATCH] arm/dt: tegra devicetree support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Jul 2011 12:47:58 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Stephen Warren <swarren@...dia.com>
Cc:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Erik Gilling <konkers@...roid.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	Colin Cross <ccross@...roid.com>,
	Olof Johansson <olof@...om.net>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH] arm/dt: tegra devicetree support

On Wed, Jul 20, 2011 at 11:40:28AM -0700, Stephen Warren wrote:
> Grant Likely wrote at Wednesday, July 20, 2011 12:32 PM:
> > The compatible property here definitely represents the hardware
> > because it reflects the sound infrastructure on the harmony board.
> 
> I can see that argument for "nvidia,harmony-sound".
> 
> But "nvidia,tegra-wm8903" is pretty generic; I can certainly see there
> being Tegra 20 systems that use a WM8903 but are so different from either
> Harmony or anything supported by sound/soc/tegra/tegra_wm8903.c that the
> existing driver isn't applicable. And hence, there may be a different
> ASoC driver for such board(s), and hence choosing such a generic name as
> "tegra-wm8903" for Harmony/Seaboard's audio layout seems like it might
> cause problems in the future.
> 
> I'm fine with such a generic name for the platform driver, since that name
> can fairly easily be modified just by editing the driver and the board file.
> But since *.dts files are at least logically separate from the kernel, such
> naming future-proofing is a little more important.

Sure, the tegra-wm8903 property can be dropped.  If we start to see a
really well established pattern of the tegra paired with a wm8903,
then at that point we can define a compatible property for it and
document exactly what it means (document the boundaries and
assumptions that the compatible value requires).

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/