linux-kernel - Re: linux-next: Tree for July 20 (overlayfs)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+icZUXf1_qWF8GdQyCVxzAp-CYgQbH8iod0oBTjhWsSZLi1_g@mail.gmail.com>
Date:	Wed, 20 Jul 2011 21:28:29 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	Al Viro <viro@...iv.linux.org.uk>,
	Randy Dunlap <rdunlap@...otime.net>
Subject: Re: linux-next: Tree for July 20 (overlayfs)

On Wed, Jul 20, 2011 at 8:48 PM, Sedat Dilek <sedat.dilek@...glemail.com> wrote:
> Hi,
>
> I have here a problem with linux-next (next-20110720) and
> overlayfs-v10 (not the latest from GIT).
>
> ### OVERLAYFS
> # Patches from mszeredi/vfs.git#overlayfs.v10 (up to commit
> 00b27467b181a27c808cef0d66860eba5f450b24)
> # "overlay: overlay filesystem documentation"
> # See also <http://lkml.org/lkml/2011/6/1/456>
> # "[PATCH 0/7] overlay filesystem: request for inclusion"
> + overlayfs-v10/overlayfs-v10.patch
>
> Documentation/filesystems/porting says:
>
> [mandatory]
>        ->permission(), generic_permission() and ->check_acl() have lost flags
> argument; instead of passing IPERM_FLAG_RCU we add MAY_NOT_BLOCK into mask.
>        generic_permission() has also lost the check_acl argument; if you want
> non-NULL to be used for that inode, put it into ->i_op->check_acl.
>
> I checked with other files below fs/ and changed accordingly.
> So, I hope the attached patch is OK (untested, uncompiled)?
>
> What's the status of OverlayFS anyway, will it be merged into v3.1?
>
> Regards,
> - Sedat -
>

I checked again and adapted ovl_permission().

[ fs/namei.c ]
static int acl_permission_check(struct inode *inode, int mask)

Here is a v2, which compiles.

- Sedat -

Download attachment "fs-overlayfs-inode.c-v2.diff" of type "plain/text" (2185 bytes)