linux-kernel - RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74CDBE0F657A3D45AFBB94109FB122FF049EBDEF4E@HQMAIL01.nvidia.com>
Date:	Wed, 20 Jul 2011 12:51:08 -0700
From:	Stephen Warren <swarren@...dia.com>
To:	Andrew Chew <AChew@...dia.com>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"olof@...om.net" <olof@...om.net>,
	Dan Willemsen <dwillemsen@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Venkat Moganty <vmoganty@...dia.com>
CC:	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Chew <AChew@...dia.com>
Subject: RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

achew@...dia.com wrote at Wednesday, July 20, 2011 1:38 PM:
> From: Andrew Chew <achew@...dia.com>
> 
> Add code to try to get platform data information (register base, irq,
> modes, various tuning parameters) from device tree, if not present in board
> files.
> 
> Signed-off-by: Andrew Chew <achew@...dia.com>

> +++ b/Documentation/devicetree/bindings/usb/tegra20-ehci.txt
...
> +Required properties for type = "ulpi":
> + - reset_gpio: The GPIO used to drive reset
> + - clk

We should probably document what this is. I know you're finding out more
about this internally.

> diff --git a/drivers/usb/host/ehci-tegra.c b/drivers/usb/host/ehci-tegra.c
> +	retval = of_property_read_u32(dn, "power_down_on_bus_suspend",
> +				      &pdata->power_down_on_bus_suspend);

Sorry I missed this before, but perhaps we should skip reading that
property unless mode=="host"?

Otherwise,
Acked-by: Stephen Warren <swarren@...dia.com>

-- 
nvpublic

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/