linux-kernel - Re: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACxGe6tEEr11vd3tqDwQ00YhUi7tMzovmS2PZGW9jt1K6VBefg@mail.gmail.com>
Date:	Wed, 20 Jul 2011 14:19:16 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Andrew Chew <AChew@...dia.com>
Cc:	"olof@...om.net" <olof@...om.net>,
	Stephen Warren <swarren@...dia.com>,
	Dan Willemsen <dwillemsen@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Venkat Moganty <vmoganty@...dia.com>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

On Wed, Jul 20, 2011 at 2:16 PM, Andrew Chew <AChew@...dia.com> wrote:
>> Can the driver use sane defaults for any of these values?  This patch
>> will be a lot smaller if there isn't the need to check all the return
>> values each time.
>
> The defaults are in the dt ehci node.  I'd really hate to duplicate these defaults in C code as well, if that's what you're suggesting (they're already duplicated privately elsewhere, sadly, in mach-tegra, but I'm hoping those defaults can go away once we move over to dt for good).  By failing probe if these defaults aren't present, I think it helps make sure the dt ehci node stays in sync with the code.

I'm saying that if the binding and the driver encode sane defaults for
those parameters, then the properties don't need to appear in the .dts
at all unless they are being overridden.  It is by no means a critical
issue though.  Do what makes the most sense to you.

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/