linux-kernel - RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <643E69AA4436674C8F39DCC2C05F76383CF0DD227D@HQMAIL03.nvidia.com>
Date:	Wed, 20 Jul 2011 15:57:03 -0700
From:	Andrew Chew <AChew@...dia.com>
To:	Andrew Chew <AChew@...dia.com>,
	'Grant Likely' <grant.likely@...retlab.ca>
CC:	"'olof@...om.net'" <olof@...om.net>,
	Stephen Warren <swarren@...dia.com>,
	Dan Willemsen <dwillemsen@...dia.com>,
	Rhyland Klein <rklein@...dia.com>,
	Venkat Moganty <vmoganty@...dia.com>,
	"'devicetree-discuss@...ts.ozlabs.org'" 
	<devicetree-discuss@...ts.ozlabs.org>,
	"'linux-tegra@...r.kernel.org'" <linux-tegra@...r.kernel.org>,
	"'linux-usb@...r.kernel.org'" <linux-usb@...r.kernel.org>,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/3 v2] usb: tegra20-ehci: Add devicetree support.

> > > +Required properties for type = "utmi".  These values are 
> > derived from
> > > +characterization by system engineering.
> > > + - hssync_start_delay
> > > + - idle_wait_delay
> > > + - elastic_limit
> > > + - term_range_adj
> > > + - xcvr_setup
> > > + - xcvr_lsfslew
> > > + - xcvr_lsrslew
> > 
> > All of these custom properties should be prefixed with "nvidia," to
> > avoid namespace collisions.
> 
> Are you saying we should prefix with "nvidia," on ALL of the 
> properties I've defined for the tegra20-ehci node?  Or 
> specifically those seven that you pointed out?  Because I 
> don't see a difference in terms of "custom"-ality between 
> say, hssync-start-delay, and the other stuff like phy-type, 
> mode, power-down-on-bus-suspend, and the reset-gpio and clk 
> from phy-type=ulpi...unless we're considering stuff like 
> phy-type to be a standard USB host controller node property.

Looking around for precedence, I see that fsl-usb.txt documents a phy-type as well as a dr-mode (though there's still underscores in that document...I assume they will be replaced by hyphens at some point).  So I think the tegra2 ehci host driver will mirror that, and use those property names, in which case I assume we don't have a vendor prefix on those.  Are "standard" usb host controller properties (those that shouldn't have a vendor prefix) documented anywhere?--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/