linux-kernel - Re: [PATCH] HID: emsff: properly handle emsff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107201156130.7300@pobox.suse.cz>
Date:	Wed, 20 Jul 2011 11:56:22 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org, Ignaz Forster <ignaz.forster@....de>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: emsff: properly handle emsff_init failure

On Tue, 19 Jul 2011, Axel Lin wrote:

> emsff_init() may fail, let's properly handle the failure.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/hid/hid-emsff.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-emsff.c b/drivers/hid/hid-emsff.c
> index 81877c6..a5dc13f 100644
> --- a/drivers/hid/hid-emsff.c
> +++ b/drivers/hid/hid-emsff.c
> @@ -126,7 +126,12 @@ static int ems_probe(struct hid_device *hdev, const struct hid_device_id *id)
>  		goto err;
>  	}
>  
> -	emsff_init(hdev);
> +	ret = emsff_init(hdev);
> +	if (ret) {
> +		dev_err(&hdev->dev, "force feedback init failed\n");
> +		hid_hw_stop(hdev);
> +		goto err;
> +	}
>  
>  	return 0;
>  err:

Good catch, applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/