linux-kernel - Re: [PATCH -tip v2 4/6] perf script: print DSOs and symbols for BTS branch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E27F332.8020501@hitachi.com>
Date:	Thu, 21 Jul 2011 18:36:50 +0900
From:	Akihiro Nagai <akihiro.nagai.hw@...achi.com>
To:	David Ahern <dsahern@...il.com>
Cc:	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	yrl.pp-manager.tt@...achi.com, Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH -tip v2 4/6] perf script: print DSOs and symbols for BTS
 branch_from addr

(2011/07/18 1:22), David Ahern wrote:
>
>
> On 07/17/2011 03:31 AM, Akihiro Nagai wrote:
>> Print DSOs and symbols for branch_from address of BTS.
>> BTS records branch_from address in 'addr' fields,
>> and branch_to address in 'ip' field. Latest perf-script
>> resolves DSOs and symbols only for 'ip' field.
>> This patch resolves them for 'addr' field too.
>
> Description does not match code change. What you are doing is enhancing
> the detection of when a sample address should correlate to a symbol. In
> this case you are adding HW_BRANCH_INSTRUCTIONS event.
I see. In the next patch set, I'd like to fix it. For example,
"Enhance IP and ADDR correlation detection of BTS event"

Thank you.

>
> David
>
>
>>
>> # perf script -f ip,addr,dso,sym
>> 3f03e016b0 (unknown) ([kernel.kallsyms]) ffffffff814675d2 irq_return ([kernel.kallsyms])
>> 3f03e016b0    _start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
>> 3f03e04b80 _dl_start (/lib64/ld-2.14.so)       3f03e016b3 _start (/lib64/ld-2.14.so)
>> 3f03e04b80 _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
>> 3f03e04ba6 _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
>> 3f03e04bad _dl_start (/lib64/ld-2.14.so) ffffffff814675d2 irq_return ([kernel.kallsyms])
>> 3f03e04c1d _dl_start (/lib64/ld-2.14.so)       3f03e04bfb _dl_start (/lib64/ld-2.14.so)
>> [snip]
>>
>> Signed-off-by: Akihiro Nagai<akihiro.nagai.hw@...achi.com>
>> Cc: Peter Zijlstra<peterz@...radead.org>
>> Cc: Frederic Weisbecker<fweisbec@...il.com>
>> Cc: Paul Mackerras<paulus@...ba.org>
>> Cc: Ingo Molnar<mingo@...e.hu>
>> Cc: Arnaldo Carvalho de Melo<acme@...radead.org>
>> Cc: David Ahern<dsahern@...il.com>
>> Cc: Masami Hiramatsu<masami.hiramatsu.pt@...achi.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/