linux-kernel - Re: [patch]drivers:net:Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110721093856.GA5327@udknight>
Date:	Thu, 21 Jul 2011 17:38:56 +0800
From:	wangyanqing <udknight@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch]drivers:net:Kconfig

On Wed, Jul 20, 2011 at 02:10:19PM +0200, Eric Dumazet wrote:
> Le mercredi 20 juillet 2011 à 20:05 +0800, wangyanqing a écrit :
> > Broadcom Tigon3 driver tg3.ko can't work without the Broadcom PHY,
> >  so maybe we should add a dependence on it.Or at least we should add
> >  notice in the help txt.
> > 
> > Signed-off-by: wang yanqing <udknight@...il.com>
> > ---
> >  drivers/net/Kconfig |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> > index 93359fa..c2607cd 100644
> > --- a/drivers/net/Kconfig
> > +++ b/drivers/net/Kconfig
> > @@ -2353,7 +2353,7 @@ config VIA_VELOCITY
> >  
> >  config TIGON3
> >  	tristate "Broadcom Tigon3 support"
> > -	depends on PCI
> > +	depends on PCI && BROADCOM_PHY
> >  	select PHYLIB
> >  	help
> >  	  This driver supports Broadcom Tigon3 based gigabit Ethernet cards.
> 
> Hmm.
> 
> When do you plan to answer to my previous question ?
> 
> I said :
> 
> Thats strange.
> 
> Here I have a (running) tg3 adapter, but
> 
> $ zgrep BROADCOM /proc/config.gz
> # CONFIG_BROADCOM_PHY is not set
> 
> Could you elaborate ?
> 
> 
Sorry,but the bad postfix rule let me miss your reply.HOHO, it seems that David have given a answer.
I attach my config and lspci


View attachment "config" of type "text/plain" (87151 bytes)

View attachment "lspci.txt" of type "text/plain" (1484 bytes)