linux-kernel - Re: [PATCH] HID: prodikeys: make needlessly global symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107211359300.7300@pobox.suse.cz>
Date:	Thu, 21 Jul 2011 13:59:42 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Don Prince <dhprince.devel@...oo.co.uk>,
	linux-input@...r.kernel.org
Subject: Re: [PATCH] HID: prodikeys: make needlessly global symbols static

On Thu, 21 Jul 2011, Axel Lin wrote:

> The following symbols are not referenced outside this file so
> there's no need for it to be in the global name space.
> 
>   pcmidi_sustained_note_release
>   init_sustain_timers
>   stop_sustain_timers
>   pcmidi_handle_report
>   pcmidi_setup_extra_keys
>   pcmidi_snd_initialise
>   pcmidi_snd_terminate
> 
> Make them static.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/