linux-kernel - Re: [PATCH 1/1] Fix potentially dangerous trailing ';' in #defined values/expressions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1107211410160.7300@pobox.suse.cz>
Date:	Thu, 21 Jul 2011 14:10:36 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Phil Carmody <ext-phil.2.carmody@...ia.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Fix potentially dangerous trailing ';' in #defined
 values/expressions

On Thu, 14 Jul 2011, Phil Carmody wrote:

> All these are instances of
>   #define NAME value;
> or
>   #define NAME(params_opt) value;
> 
> These of course fail to build when used in contexts like
>   if(foo $OP NAME)
>   while(bar $OP NAME)
> and may silently generate the wrong code in contexts such as
>   foo = NAME + 1;    /* foo = value; + 1; */
>   bar = NAME - 1;    /* bar = value; - 1; */
>   baz = NAME & quux; /* baz = value; & quux; */
>
> Reported on comp.lang.c,
> Message-ID: <ab0d55fe-25e5-482b-811e-c475aa6065c3@...g2000yqd.googlegroups.com>
> Initial analysis of the dangers provided by Keith Thompson in that thread.
> 
> There are many more instances of more complicated macros having unnecessary
> trailing semicolons, but this pile seems to be all of the cases of simple
> values suffering from the problem. (Thus things that are likely to be found
> in one of the contexts above, more complicated ones aren't.)
> 
> Signed-off-by: Phil Carmody <ext-phil.2.carmody@...ia.com>

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/