linux-kernel - Re: [tip:perf/core] perf: Remove the nmi parameter from the swevent and overflow interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110721141027.GA8446@e102144-lin.cambridge.arm.com>
Date:	Thu, 21 Jul 2011 15:10:27 +0100
From:	Will Deacon <will.deacon@....com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	"mingo@...hat.com" <mingo@...hat.com>,
	"dengcheng.zhu@...il.com" <dengcheng.zhu@...il.com>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"dzickus@...hat.com" <dzickus@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"anton@...ba.org" <anton@...ba.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"jason.wessel@...driver.com" <jason.wessel@...driver.com>,
	"lethal@...ux-sh.org" <lethal@...ux-sh.org>,
	"emunson@...bm.net" <emunson@...bm.net>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"mcree@...on.net.nz" <mcree@...on.net.nz>,
	"mingo@...e.hu" <mingo@...e.hu>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:perf/core] perf: Remove the nmi parameter from the
 swevent and overflow interface

Hi Peter,

On Fri, Jul 08, 2011 at 06:41:16PM +0100, Peter Zijlstra wrote:
> On Fri, 2011-07-08 at 18:34 +0100, Will Deacon wrote:
> > On Fri, Jul 01, 2011 at 04:21:25PM +0100, tip-bot for Peter Zijlstra wrote:
> > > Commit-ID:  a8b0ca17b80e92faab46ee7179ba9e99ccb61233
> > > Gitweb:     http://git.kernel.org/tip/a8b0ca17b80e92faab46ee7179ba9e99ccb61233
> > > Author:     Peter Zijlstra <a.p.zijlstra@...llo.nl>
> > > AuthorDate: Mon, 27 Jun 2011 14:41:57 +0200
> > > Committer:  Ingo Molnar <mingo@...e.hu>
> > > CommitDate: Fri, 1 Jul 2011 11:06:35 +0200
> > > 
> > > perf: Remove the nmi parameter from the swevent and overflow interface

[...]

> > 
> > Whilst you updated the arch code in this series, you forgot to update the
> > oprofile perf backend. 
> 
> Bah, I bet it skillfully hid from my grep-foo.
> 
> > I think you want something as simple as:
> > 
> > 
> > diff --git a/drivers/oprofile/oprofile_perf.c b/drivers/oprofile/oprofile_perf.c
> > index 59acf9e..94796f3 100644
> > --- a/drivers/oprofile/oprofile_perf.c
> > +++ b/drivers/oprofile/oprofile_perf.c
> > @@ -31,7 +31,7 @@ static int num_counters;
> >  /*
> >   * Overflow callback for oprofile.
> >   */
> > -static void op_overflow_handler(struct perf_event *event, int unused,
> > +static void op_overflow_handler(struct perf_event *event,
> >                         struct perf_sample_data *data, struct pt_regs *regs)
> >  {
> >         int id;
> > 
> 
> Yes, that is sufficient. Thanks!

I can't see this in next. Are you happy taking this or do you want me to
post it to the list as a standalone patch?

Cheers,

Will
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/