linux-kernel - Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKTCnzkdZyidG3Qsdt7wFhkQMcz1wJCHY9AezSvb4rT4KTjMnQ@mail.gmail.com>
Date:	Thu, 21 Jul 2011 21:19:55 +0530
From:	Balbir Singh <bsingharora@...il.com>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Jerome Marchand <jmarchan@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] taskstats: add_del_listener() should ignore !valid listener's

On Thu, Jul 21, 2011 at 12:30 AM, Oleg Nesterov <oleg@...hat.com> wrote:
> When send_cpu_listeners() finds the orphaned listener it marks
> it as !valid and drops listeners->sem. Before it takes this sem
> for wrinting, s->pid can be reused and add_del_listener() can
> wrongly try to re-use this entry.
>
> Change add_del_listener() to check ->valid = T.
>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>

Acked-by: Balbir Singh <bsingharora@...il.com>

BTW, some namespace changes are pending from my side. I need to get
it, its on my TODO list

Balbir Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/